Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/ERC20-token-transfer-across-chains #1572

Merged
merged 7 commits into from
Jun 3, 2024
Merged

Feature/ERC20-token-transfer-across-chains #1572

merged 7 commits into from
Jun 3, 2024

Conversation

vivekjain23
Copy link
Contributor

Description of change

This Pull Request updates the documentation for compiling contracts in the LayerZero OFT V2 repository. The changes aim to provide instructions for transferring standard ERC20 contracts and custom wSMR/wIOTA tokens across chains.

Resolved issue 404

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own changes
  • I have made sure that added/changed links still work
  • I have commented my code, particularly in hard-to-understand areas

lucas-tortora
lucas-tortora requested changes May 28, 2024
View reviewed changes
docs/build/isc/v1.0.0-rc.6/docs/how-tos/send-ERC20-across-chains.md Outdated Show resolved Hide resolved
docs/build/isc/v1.0.0-rc.6/docs/how-tos/send-ERC20-across-chains.md Outdated Show resolved Hide resolved
docs/build/isc/v1.0.0-rc.6/docs/how-tos/send-ERC20-across-chains.md Outdated Show resolved Hide resolved
docs/build/isc/v1.0.0-rc.6/docs/how-tos/send-ERC20-across-chains.md Outdated Show resolved Hide resolved
docs/build/isc/v1.0.0-rc.6/docs/how-tos/send-ERC20-across-chains.md Outdated Show resolved Hide resolved
docs/build/isc/v1.0.0-rc.6/docs/how-tos/send-ERC20-across-chains.md Outdated Show resolved Hide resolved
docs/build/isc/v1.0.0-rc.6/docs/how-tos/send-ERC20-across-chains.md Outdated Show resolved Hide resolved
docs/build/isc/v1.0.0-rc.6/docs/how-tos/send-ERC20-across-chains.md Outdated Show resolved Hide resolved
docs/build/isc/v1.0.0-rc.6/docs/how-tos/send-ERC20-across-chains.md Outdated Show resolved Hide resolved
docs/build/isc/v1.0.0-rc.6/docs/how-tos/send-ERC20-across-chains.md Outdated Show resolved Hide resolved
@vivekjain23
Copy link
Contributor Author

vivekjain23 commented May 30, 2024 •
edited
Loading

Thank you for your valuable insights, I have added the changes in the new commit.

@Dr-Electron
Copy link
Collaborator

Can you do me one more favour? 😅
Please rebase on top of isc-update there you will also have to duplicate your content as we started to version wasp.
So there is a 1.1 and 1.3 folder.

@vivekjain23 vivekjain23 force-pushed the feature/ERC20-token-transfer-across-chains branch from 62a9763 to 95d9003 Compare June 3, 2024 13:04
@lucas-tortora
fixed headers (#1591)
59c6afa 
added links to headers
@vivekjain23 vivekjain23 changed the base branch from main to isc-update June 3, 2024 15:24
@Dr-Electron Dr-Electron merged commit 58c1a31 into isc-update Jun 3, 2024
@Dr-Electron Dr-Electron deleted the feature/ERC20-token-transfer-across-chains branch June 3, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucas-tortora lucas-tortora lucas-tortora approved these changes

@jlvandenhout jlvandenhout Awaiting requested review from jlvandenhout

@Dr-Electron Dr-Electron Awaiting requested review from Dr-Electron

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vivekjain23 @Dr-Electron @lucas-tortora